Fixes (field name length, unicode chars)#22
Conversation
lumpov
commented
Jul 31, 2017
lumpov
commented
- fix field name length bug.
- fix bug with unicode characters, it needs to save as is from buffer, without .toString()
…needs to save as is from buffer, without .toString()
sheindel
left a comment
sheindel
left a comment
There was a problem hiding this comment.
Because this change is a little more involved than other PRs, would you be willing to add some unit tests to demonstrate this working? I know these PRs have been stale for a while. so if not, it may just take me some time to get around to this. Thanks!
| field_meta.forEach(function(f, i) { | ||
| // field name | ||
| f.name.split('').slice(0, 8).forEach(function(c, x) { | ||
| f.name.split('').slice(0, 9).forEach(function(c, x) { |
There was a problem hiding this comment.
This has actually been fixed in another PR now, and the value should actually be 10.
|
The field name bug is fixed and because of browsers not having support for |
2 participants
